Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

分页条数不能配置 #608

Closed
vellengs opened this issue Nov 25, 2017 · 14 comments
Closed

分页条数不能配置 #608

vellengs opened this issue Nov 25, 2017 · 14 comments

Comments

@vellengs
Copy link

image
@tigercosmos
Copy link
Contributor

Use nzPageSize

@vellengs
Copy link
Author

No, I mean the options can't config.

@vellengs
Copy link
Author

I saw that's hard code.

@tigercosmos
Copy link
Contributor

Ah! I see.
This should be improved!

@hllinc
Copy link
Contributor

hllinc commented Nov 28, 2017

Omg!

@hllinc
Copy link
Contributor

hllinc commented Nov 28, 2017

I had add this function in the source code, but I cannot submit.

@vthinkxie
Copy link
Member

@hllinc please do not merge 0.5.x to master, you should rebase your code first.

@hllinc
Copy link
Contributor

hllinc commented Nov 28, 2017

Sorry, I cannot commit code now.@vthinkxie

@hllinc
Copy link
Contributor

hllinc commented Nov 28, 2017 •
edited
Loading

how can i push my code to master? @vthinkxie

@vthinkxie
Copy link
Member

@hllinc just start a new pr

@hllinc hllinc mentioned this issue Nov 28, 2017
Closed
3 tasks
hllinc added a commit to hllinc/ng-zorro-antd that referenced this issue Nov 28, 2017
@hllinc
feat(module:table and pagination): support custom the page size chang…
9113fec 
…er select values(NG-ZORRO#608)
@hllinc hllinc mentioned this issue Nov 28, 2017
Merged
3 tasks
@hllinc
Copy link
Contributor

hllinc commented Nov 28, 2017 •
edited
Loading

a new pr is start, please check it and update the package as soon as possible. our projects is waiting for using, thank you very much.@vthinkxie

@vthinkxie
Copy link
Member

@hllinc we will review it soon

@hllinc
Copy link
Contributor

hllinc commented Nov 28, 2017

@vthinkxie check failed?

@lock
Copy link

lock bot commented Feb 18, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 18, 2019
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@hllinc @vthinkxie
feat(module:table and pagination): support custom the page size chang…
3ad3641 
…er select values(NG-ZORRO#608) (NG-ZORRO#626)

* feat(module:table and pagination): support custom the page size changer select values(NG-ZORRO#608)

* style(module:table and pagination): modify the code annotation.
close NG-ZORRO#608
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hllinc @vthinkxie @vellengs @tigercosmos