Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): selector cannot focus #6073

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

hsuanxyz
Copy link
Member

close #6063

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 19, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 19, 2020

Codecov Report

Merging #6073 (8689f10) into master (3204927) will decrease coverage by 0.07%.
The diff coverage is 65.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6073      +/-   ##
==========================================
- Coverage   89.89%   89.82%   -0.08%     
==========================================
  Files         465      465              
  Lines       14057    14078      +21     
  Branches     2311     2315       +4     
==========================================
+ Hits        12636    12645       +9     
- Misses        873      882       +9     
- Partials      548      551       +3     
Impacted Files Coverage Δ
components/tree-select/tree-select.component.ts 90.13% <65.21%> (-3.43%) ⬇️
components/table/src/table-data.service.ts 78.46% <0.00%> (-6.16%) ⬇️
components/time-picker/time-holder.ts 95.78% <0.00%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3204927...8689f10. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 032bd01 into NG-ZORRO:master Nov 19, 2020
@hsuanxyz hsuanxyz deleted the fix/tree-foucs branch November 19, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeSelect is not focused on tab navigation
1 participant