Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): nzTabBarGutter is not work in vertical position #5998

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Nov 2, 2020

close #5396

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #5396

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Nov 2, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Nov 2, 2020

Codecov Report

Merging #5998 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5998   +/-   ##
=======================================
  Coverage   89.95%   89.95%           
=======================================
  Files         465      465           
  Lines       14044    14044           
  Branches     2307     2307           
=======================================
  Hits        12633    12633           
  Misses        863      863           
  Partials      548      548           
Impacted Files Coverage Δ
components/tabs/tabset.component.ts 86.20% <ø> (ø)
components/tabs/tab-nav-bar.component.ts 81.62% <0.00%> (-0.71%) ⬇️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50f0744...2f20f74. Read the comment docs.

@hsuanxyz hsuanxyz merged commit 516bf97 into NG-ZORRO:master Nov 6, 2020
@hsuanxyz hsuanxyz deleted the fix/tabs-gutter branch November 6, 2020 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

当tabset组件的position不为top时,nzTabBarGutter属性设置错误
1 participant