fix(module:upload): ensure i18n$ is defined on unsubscribe

[aitboudad]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/NG-ZORRO/ng-zorro-antd/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix

What is the current behavior?

if the upload component is destroyed before the ngOnInit call, I got the following error:

Cannot read property 'unsubscribe' of undefined
at NzUploadComponent.ngOnDestroy 

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[zorro-bot]

This preview will be available after the AzureCI is passed.

[codecov]

Codecov Report

Merging #5971 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5971      +/-   ##
==========================================
- Coverage   89.96%   89.96%   -0.01%     
==========================================
  Files         465      465              
  Lines       14047    14046       -1     
  Branches     2311     2308       -3     
==========================================
- Hits        12638    12636       -2     
- Misses        859      862       +3     
+ Partials      550      548       -2     

Impacted Files	Coverage Δ
components/upload/upload.component.ts	98.29% <100.00%> (+0.02%)	⬆️
components/table/src/table/tbody.component.ts	85.71% <0.00%> (-14.29%)	⬇️
components/table/src/table/tr-measure.component.ts	86.36% <0.00%> (-13.64%)	⬇️
components/date-picker/picker.component.ts	89.47% <0.00%> (-1.10%)	⬇️
components/time-picker/time-holder.ts	94.73% <0.00%> (-1.06%)	⬇️
components/date-picker/date-picker.component.ts	92.30% <0.00%> (-0.06%)	⬇️
components/date-picker/lib/abstract-table.ts	89.58% <0.00%> (ø)
components/date-picker/inner-popup.component.ts	86.95% <0.00%> (ø)
...mponents/date-picker/date-range-popup.component.ts	91.86% <0.00%> (+0.14%)	⬆️
components/select/select.component.ts	87.54% <0.00%> (+0.42%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a00b69...5806f81. Read the comment docs.

[hsuanxyz]

Thanks for your contribution, could you modify it like the following? Just like the other components.

import { takeUntil } from 'rxjs/operators';

class NzUploadComponent {
   private destroy$ = new Subject<void>();

  ngOnInit(): void {
    this.i18n.localeChange.pipe(takeUntil(this.destroy$)).subscribe(() => {
      this.locale = this.i18n.getLocaleData('Upload');
      this.detectChangesList();
    });
  }

  ngOnDestroy(): void {
    this.destroy$.next();
    this.destroy$.complete();
  }
}

[aitboudad]

done!

[hsuanxyz]

LGTM