Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:form): remove @host so child components recieve autotips #5962

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

sorahn
Copy link
Contributor

@sorahn sorahn commented Oct 22, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Autotips do not apply to child components of a form with form controls, just direct descendants.

What is the new behavior?

Remove the @host binding so that child components can take advantage of nzAutotips

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Oct 22, 2020

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Oct 22, 2020

Codecov Report

Merging #5962 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5962      +/-   ##
==========================================
- Coverage   89.92%   89.91%   -0.01%     
==========================================
  Files         463      463              
  Lines       13965    13965              
  Branches     2289     2289              
==========================================
- Hits        12558    12557       -1     
- Misses        867      869       +2     
+ Partials      540      539       -1     
Impacted Files Coverage Δ
components/form/form-control.component.ts 93.96% <100.00%> (ø)
components/table/src/table-data.service.ts 78.46% <0.00%> (-6.16%) ⬇️
components/time-picker/time-holder.ts 94.73% <0.00%> (-1.06%) ⬇️
components/tabs/tab-nav-bar.component.ts 83.03% <0.00%> (+0.70%) ⬆️
components/core/util/text-measure.ts 91.30% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa4ac2b...b9295d1. Read the comment docs.

@vthinkxie vthinkxie changed the title [autotips-fix] remove @Host so child components recieve autotips fix(module:form): remove @host so child components recieve autotips Oct 22, 2020
@danranVm
Copy link
Member

LGTM.

@hsuanxyz hsuanxyz merged commit 705d6d8 into NG-ZORRO:master Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants