Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DatePicker: should open panel when input change #5284

Closed
wenqi73 opened this issue May 14, 2020 · 1 comment
Closed

DatePicker: should open panel when input change #5284

wenqi73 opened this issue May 14, 2020 · 1 comment
Labels
Component: DatePicker Good First Issue Issues recommended for first-time contributor help wanted

Comments

@wenqi73
Copy link
Member

wenqi73 commented May 14, 2020 •
edited
Loading

From #5188 (comment).
@wenqi73 wenqi73 self-assigned this May 14, 2020
@wenqi73 wenqi73 mentioned this issue May 14, 2020
Closed
@wenqi73 wenqi73 added Good First Issue Issues recommended for first-time contributor help wanted labels May 14, 2020
@zorro-bot
Copy link

zorro-bot bot commented May 14, 2020

Hello @wenqi73. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please fill the Pull Request Template here, provide documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @wenqi73, 我们完全同意你的提议/反馈，欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板，提供改动所需相应的测试用例、文档等，并确保 CI 通过，我们会尽快进行 Review，提前感谢和期待您的贡献！
giphy

@wenqi73 wenqi73 removed their assignment May 14, 2020
@wenqi73 wenqi73 changed the title DatePicker: can change value when panel is closed DatePicker: should open panel when input change May 15, 2020
@wenqi73 wenqi73 mentioned this issue Jun 12, 2020
Closed
qiurenbo added a commit to qiurenbo/ng-zorro-antd that referenced this issue Jun 23, 2020
@qiurenbo
fix(module:datepicker): fix open panel when input change (NG-ZORRO#5284)
af7f381
@qiurenbo qiurenbo mentioned this issue Jun 23, 2020
Merged
3 tasks
qiurenbo added a commit to qiurenbo/ng-zorro-antd that referenced this issue Jun 23, 2020
@qiurenbo
refactor(module:datepicker): minimize onInputKeyup function(NG-ZORRO#…
d341c72 
…5284)
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@qiurenbo
fix(module:datepicker): not open panel when input change(NG-ZORRO#5466)
c93c6bc 
close NG-ZORRO#5284 
close NG-ZORRO#5411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: DatePicker Good First Issue Issues recommended for first-time contributor help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wenqi73