Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix handle transform in vertical mode #4939

Merged
merged 1 commit into from
Apr 14, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 24, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix, a style bug fix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Mar 24, 2020

This preview will be available after the AzureCI is passed.

@wzhudev wzhudev requested a review from hsuanxyz March 24, 2020 13:32
@codecov
Copy link

codecov bot commented Mar 24, 2020

Codecov Report

Merging #4939 into master will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4939      +/-   ##
==========================================
+ Coverage   91.53%   91.83%   +0.30%     
==========================================
  Files         535      545      +10     
  Lines       13686    14950    +1264     
  Branches     2043     2390     +347     
==========================================
+ Hits        12527    13729    +1202     
- Misses        694      749      +55     
- Partials      465      472       +7     
Impacted Files Coverage Δ
components/slider/handle.component.ts 96.15% <100.00%> (ø)
components/table/src/cell/td-addon.component.ts 79.41% <0.00%> (-7.55%) ⬇️
components/i18n/date-helper.service.ts 85.00% <0.00%> (-1.85%) ⬇️
components/core/util/text-measure.ts 89.56% <0.00%> (-1.74%) ⬇️
components/table/src/cell/th-addon.component.ts 83.18% <0.00%> (-1.03%) ⬇️
components/table/src/table-data.service.ts 88.63% <0.00%> (-0.46%) ⬇️
components/tooltip/tooltip.ts 100.00% <0.00%> (ø)
components/popconfirm/popconfirm.ts 100.00% <0.00%> (ø)
components/table/src/table.module.ts 100.00% <0.00%> (ø)
components/table/src/addon/sorters.component.ts 100.00% <0.00%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44155a3...93fcccc. Read the comment docs.

@wzhudev wzhudev closed this Apr 7, 2020
@wzhudev wzhudev deleted the slider-transform branch April 7, 2020 02:18
@wzhudev wzhudev restored the slider-transform branch April 7, 2020 02:18
@wzhudev wzhudev reopened this Apr 7, 2020
@hsuanxyz hsuanxyz merged commit 6fba78d into NG-ZORRO:master Apr 14, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
@wzhudev wzhudev deleted the slider-transform branch April 15, 2020 13:48
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants