-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:date-picker): add some inputs #4843
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #4843 +/- ##
==========================================
- Coverage 92.95% 92.92% -0.04%
==========================================
Files 505 505
Lines 12722 12733 +11
Branches 1971 1964 -7
==========================================
+ Hits 11826 11832 +6
- Misses 472 475 +3
- Partials 424 426 +2
Continue to review full report at Codecov.
|
7d9c284
to
a38b6a3
Compare
@@ -207,13 +216,24 @@ export class NzPickerComponent implements AfterViewInit, OnChanges, OnDestroy { | |||
inputWidth + | |||
((this.elementRef.nativeElement as HTMLElement).querySelector('.ant-picker-range-separator') as HTMLElement).offsetWidth; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里最好用指令去代替 DOM query
@Directive({
selector: '[nz-picker-range-separator]',
exportAs: 'nzIcon',
host: {
class: 'ant-picker-range-separator'
}
})
export class NzPockerRangeSeparator {
constructor(
public elementRef: ElementRef
) {
}
}
@ViewChlid(NzPockerRangeSeparator) nzPockerRangeSeparator: NzPockerRangeSeparator;
* feat(module:date-picker): add nzDefaultPickerValue * feat: add nzSeparator * fix: reduce dom structure to make host style work
* feat(module:date-picker): add nzDefaultPickerValue * feat: add nzSeparator * fix: reduce dom structure to make host style work
Close #2020
Close #1614
Close #4148
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information