Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:radio): refactor radio group data flow #4770

Merged
merged 1 commit into from
Feb 11, 2020
Merged

perf(module:radio): refactor radio group data flow #4770

merged 1 commit into from
Feb 11, 2020

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #4770 into master will increase coverage by 0.04%.
The diff coverage is 98.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4770      +/-   ##
==========================================
+ Coverage   93.19%   93.24%   +0.04%     
==========================================
  Files         506      507       +1     
  Lines       12754    12752       -2     
  Branches     1962     1959       -3     
==========================================
+ Hits        11886    11890       +4     
+ Misses        454      450       -4     
+ Partials      414      412       -2
Impacted Files Coverage Δ
components/radio/radio.module.ts 100% <ø> (ø)
components/radio/radio-group.component.ts 100% <100%> (ø)
components/radio/radio.service.ts 100% <100%> (ø)
components/radio/radio-button.directive.ts 100% <100%> (ø)
components/radio/radio.component.ts 97.01% <97.01%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299ba6d...706279d. Read the comment docs.

@vthinkxie vthinkxie merged commit 423a382 into NG-ZORRO:master Feb 11, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants