Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tag): support status colors #4628

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Jan 2, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4622, #4413

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@zorro-bot
Copy link

zorro-bot bot commented Jan 2, 2020

This preview will be available after the TravisCI is passed.

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #4628 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4628      +/-   ##
==========================================
+ Coverage   93.17%   93.17%   +<.01%     
==========================================
  Files         507      507              
  Lines       12778    12779       +1     
  Branches     2023     2024       +1     
==========================================
+ Hits        11906    11907       +1     
- Misses        454      455       +1     
+ Partials      418      417       -1
Impacted Files Coverage Δ
components/tag/nz-tag.component.ts 97.36% <100%> (+0.07%) ⬆️
components/typography/nz-typography.component.ts 98.23% <0%> (-0.89%) ⬇️
components/time-picker/time-holder.ts 97.31% <0%> (+0.67%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4d2694...118265d. Read the comment docs.

@vthinkxie vthinkxie merged commit aa22c0f into NG-ZORRO:master Jan 13, 2020
@pr-triage pr-triage bot added the PR: merged label Jan 13, 2020
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants