Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): fix not showing empty when there's no options #4565

Merged
merged 4 commits into from
Jan 9, 2020

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Dec 15, 2019

close #4562

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #4562

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Dec 15, 2019

Codecov Report

Merging #4565 into master will increase coverage by 0.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4565      +/-   ##
==========================================
+ Coverage   93.17%   93.23%   +0.06%     
==========================================
  Files         521      519       -2     
  Lines       12844    12832      -12     
  Branches     2019     2016       -3     
==========================================
- Hits        11967    11964       -3     
+ Misses        461      452       -9     
  Partials      416      416
Impacted Files Coverage Δ
components/cascader/nz-cascader.component.ts 95.41% <100%> (+0.12%) ⬆️
components/cascader/nz-cascader.service.ts 97.52% <100%> (ø) ⬆️
components/core/overlay/overlay-position.ts 92.3% <100%> (+0.64%) ⬆️
components/empty/nz-empty.service.ts 95.65% <0%> (-4.35%) ⬇️
...otification/nz-notification-container.component.ts 96.87% <0%> (-3.13%) ⬇️
...mponents/message/nz-message-container.component.ts 92.68% <0%> (-2.06%) ⬇️
components/typography/nz-typography.component.ts 98.23% <0%> (-0.89%) ⬇️
components/drawer/nz-drawer.component.ts 96.98% <0%> (-0.79%) ⬇️
components/time-picker/time-holder.ts 96.64% <0%> (-0.68%) ⬇️
components/tabs/nz-tabset.component.ts 93.1% <0%> (-0.32%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c5d24e...672932d. Read the comment docs.

Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[cascader#搜索] demo 需要重新打开才会正确显示 empty

@wzhudev
Copy link
Member Author

wzhudev commented Jan 8, 2020

@hsuanxyz It should works now.

@hsuanxyz hsuanxyz merged commit 9d8d7e6 into NG-ZORRO:master Jan 9, 2020
@wzhudev wzhudev deleted the show-cascader-empty branch January 9, 2020 12:58
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…G-ZORRO#4565)

* fix(module:cascader): fix not showing empty when there's no options

close NG-ZORRO#4562

* fix: fix style

* fix: fix dropdown style when there's no search result

* chore: remove garbage
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…G-ZORRO#4565)

* fix(module:cascader): fix not showing empty when there's no options

close NG-ZORRO#4562

* fix: fix style

* fix: fix dropdown style when there's no search result

* chore: remove garbage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cascader组件在没有数据时能否和Select组件没有数据一样出现那种No Data的面板
2 participants