Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tooltip): support changing trigger #4397

Merged
merged 2 commits into from
Nov 8, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Nov 6, 2019

close #4365

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Nov 6, 2019

Codecov Report

Merging #4397 into master will decrease coverage by 0.1%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4397      +/-   ##
==========================================
- Coverage    92.2%   92.09%   -0.11%     
==========================================
  Files         520      520              
  Lines       11039    11061      +22     
  Branches     1997     2004       +7     
==========================================
+ Hits        10178    10187       +9     
- Misses        429      443      +14     
+ Partials      432      431       -1
Impacted Files Coverage Δ
...mponents/tooltip/base/nz-tooltip-base.directive.ts 93.57% <100%> (+2.48%) ⬆️
components/core/tree/nz-tree-base.service.ts 93.62% <0%> (-0.4%) ⬇️
components/tree/nz-tree.component.ts 97.74% <0%> (-0.07%) ⬇️
components/page-header/nz-page-header.component.ts 100% <0%> (ø) ⬆️
components/core/config/config.ts 100% <0%> (ø) ⬆️
...mponents/code-editor/nz-code-editor.definitions.ts 83.33% <0%> (ø) ⬆️
components/tree-select/nz-tree-select.component.ts 98.93% <0%> (ø) ⬆️
components/modal/nz-modal.service.ts 88.67% <0%> (+0.21%) ⬆️
components/code-editor/nz-code-editor.service.ts 3.17% <0%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc3868e...9cc6e42. Read the comment docs.

@netlify
Copy link

netlify bot commented Nov 7, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 9cc6e42

https://deploy-preview-4397--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz merged commit 48d7122 into NG-ZORRO:master Nov 8, 2019
@wzhudev wzhudev deleted the tooltip-trigger-change branch November 8, 2019 09:56
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:tooltip): support changing trigger

* fix: remove listeners when directive destroys

close NG-ZORRO#4365
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:tooltip): support changing trigger

* fix: remove listeners when directive destroys

close NG-ZORRO#4365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzTooltipTrigger does not change based on property
2 participants