-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(module:icon): remove old api #4375
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wzhudev
added
PR: target-major
💔 Breaking Change
This PR or the solution to this issue would introduce breaking changes
labels
Nov 4, 2019
Deploy preview for ng-zorro-master ready! Built with commit 382d18f |
Codecov Report
@@ Coverage Diff @@
## master #4375 +/- ##
==========================================
+ Coverage 91.96% 92.01% +0.05%
==========================================
Files 517 517
Lines 10999 10926 -73
Branches 2006 1981 -25
==========================================
- Hits 10115 10054 -61
+ Misses 453 448 -5
+ Partials 431 424 -7
Continue to review full report at Codecov.
|
hsuanxyz
changed the title
feat(module:icon): remove old api
chore(module:icon): remove old api
Nov 22, 2019
wzhudev
force-pushed
the
remove-icon-api
branch
from
November 22, 2019 09:03
1c97095
to
382d18f
Compare
hsuanxyz
approved these changes
Nov 22, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:icon): remove old api * fix(module:icon): remove duplicated constructor BREAKING CHANGE: - `i[nz-icon]`: `twoToneColor` `theme` `spin` `iconfont` `type` inputs has been removed, use `nzTwoToneColor` `nzTheme` `nzSpin` `nzIconfont` `nzType` instead. - `i.anticon` selector has been removed, use `i[nz-icon]` instead.
Closed
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:icon): remove old api * fix(module:icon): remove duplicated constructor BREAKING CHANGE: - `i[nz-icon]`: `twoToneColor` `theme` `spin` `iconfont` `type` inputs has been removed, use `nzTwoToneColor` `nzTheme` `nzSpin` `nzIconfont` `nzType` instead. - `i.anticon` selector has been removed, use `i[nz-icon]` instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💔 Breaking Change
This PR or the solution to this issue would introduce breaking changes
PR: merged
PR: target-major
PR: unreviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
anticon-xxx
is removed.nz
prefix are removed.Other information