Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(module:icon): remove old api #4375

Merged
merged 2 commits into from
Nov 22, 2019
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Nov 4, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: deprecation: remove old API

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No
  • Old usage like anticon-xxx is removed.
  • Auto correction of misspelling is removed.
  • Inputs without nz prefix are removed.

Other information

@pr-triage pr-triage bot added the PR: draft label Nov 4, 2019
@wzhudev wzhudev added PR: target-major 💔 Breaking Change This PR or the solution to this issue would introduce breaking changes labels Nov 4, 2019
@wzhudev wzhudev requested a review from hsuanxyz November 4, 2019 08:09
@netlify
Copy link

netlify bot commented Nov 7, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 382d18f

https://deploy-preview-4375--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Nov 7, 2019

Codecov Report

Merging #4375 into master will increase coverage by 0.05%.
The diff coverage is 97.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4375      +/-   ##
==========================================
+ Coverage   91.96%   92.01%   +0.05%     
==========================================
  Files         517      517              
  Lines       10999    10926      -73     
  Branches     2006     1981      -25     
==========================================
- Hits        10115    10054      -61     
+ Misses        453      448       -5     
+ Partials      431      424       -7
Impacted Files Coverage Δ
components/icon/nz-icon.service.ts 97.82% <100%> (-0.26%) ⬇️
components/icon/nz-icon.directive.ts 95.83% <97.22%> (+8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82e8a6...382d18f. Read the comment docs.

@wzhudev wzhudev added this to the 9.0.0 milestone Nov 8, 2019
@wzhudev wzhudev marked this pull request as ready for review November 19, 2019 09:16
@pr-triage pr-triage bot removed the PR: draft label Nov 19, 2019
@auto-assign auto-assign bot requested a review from cipchk November 19, 2019 09:16
@hsuanxyz hsuanxyz changed the title feat(module:icon): remove old api chore(module:icon): remove old api Nov 22, 2019
@hsuanxyz hsuanxyz merged commit 91e52ab into NG-ZORRO:master Nov 22, 2019
@wzhudev wzhudev deleted the remove-icon-api branch November 22, 2019 11:40
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:icon): remove old api

* fix(module:icon): remove duplicated constructor

BREAKING CHANGE: 


- `i[nz-icon]`:  `twoToneColor` `theme` `spin` `iconfont` `type` inputs has been removed, use `nzTwoToneColor` `nzTheme` `nzSpin` `nzIconfont` `nzType` instead.
- `i.anticon` selector has been removed, use `i[nz-icon]` instead.
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:icon): remove old api

* fix(module:icon): remove duplicated constructor

BREAKING CHANGE: 


- `i[nz-icon]`:  `twoToneColor` `theme` `spin` `iconfont` `type` inputs has been removed, use `nzTwoToneColor` `nzTheme` `nzSpin` `nzIconfont` `nzType` instead.
- `i.anticon` selector has been removed, use `i[nz-icon]` instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💔 Breaking Change This PR or the solution to this issue would introduce breaking changes PR: merged PR: target-major PR: unreviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants