Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:page-header): has footer or breadcrumb style bug #4363

Merged
merged 2 commits into from
Nov 7, 2019
Merged

fix(module:page-header): has footer or breadcrumb style bug #4363

merged 2 commits into from
Nov 7, 2019

Conversation

CK110
Copy link
Member

@CK110 CK110 commented Oct 30, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

NzPageHeaderComponent don't use .has-breadcrumb .has-footer style class

What is the new behavior?

use .has-breadcrumb .has-footer style class

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Oct 30, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 6bc2ccc

https://deploy-preview-4363--ng-zorro-master.netlify.com

@hsuanxyz hsuanxyz requested review from hsuanxyz and removed request for wzhudev October 30, 2019 01:55
Copy link
Member

@hsuanxyz hsuanxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you PR, it looks good. But need to modify the it('should footer work', ...) test, and add a case to test has-breadcrumb.

@codecov
Copy link

codecov bot commented Oct 30, 2019

Codecov Report

Merging #4363 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4363      +/-   ##
==========================================
+ Coverage    92.2%   92.21%   +<.01%     
==========================================
  Files         520      520              
  Lines       11039    11040       +1     
  Branches     1997     1997              
==========================================
+ Hits        10178    10180       +2     
  Misses        429      429              
+ Partials      432      431       -1
Impacted Files Coverage Δ
components/page-header/nz-page-header.component.ts 100% <100%> (ø) ⬆️
components/time-picker/time-holder.ts 97.36% <0%> (+0.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7bae5e...6bc2ccc. Read the comment docs.

@hsuanxyz hsuanxyz merged commit dcc7deb into NG-ZORRO:master Nov 7, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…#4363)

* fix(module:page-header): has footer or breadcrumb style bug

* fix(module:page-header): add test
@hsuanxyz hsuanxyz mentioned this pull request Apr 15, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…#4363)

* fix(module:page-header): has footer or breadcrumb style bug

* fix(module:page-header): add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants