-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:page-header): has footer or breadcrumb style bug #4363
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 6bc2ccc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you PR, it looks good. But need to modify the it('should footer work', ...)
test, and add a case to test has-breadcrumb
.
Codecov Report
@@ Coverage Diff @@
## master #4363 +/- ##
==========================================
+ Coverage 92.2% 92.21% +<.01%
==========================================
Files 520 520
Lines 11039 11040 +1
Branches 1997 1997
==========================================
+ Hits 10178 10180 +2
Misses 429 429
+ Partials 432 431 -1
Continue to review full report at Codecov.
|
…#4363) * fix(module:page-header): has footer or breadcrumb style bug * fix(module:page-header): add test
…#4363) * fix(module:page-header): has footer or breadcrumb style bug * fix(module:page-header): add test
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
NzPageHeaderComponent
don't use.has-breadcrumb
.has-footer
style classWhat is the new behavior?
use
.has-breadcrumb
.has-footer
style classDoes this PR introduce a breaking change?
Other information