Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing space in pagination size changer #4038

Closed
oestrogen opened this issue Aug 21, 2019 · 0 comments
Closed

Missing space in pagination size changer #4038

oestrogen opened this issue Aug 21, 2019 · 0 comments
Assignees
@vthinkxie
Labels
Component: Pagination

Comments

@oestrogen
Copy link
Contributor

Reproduction link

https://angular-gczpas.stackblitz.io

Steps to reproduce

  • Create a pagination with nzShowSizeChanger.
  • Look at the size changer

What is expected?

The size changer should say "10 / page", with spaces on both sides of the slash, like it does in upstream Ant for React.

What is actually happening?

The size changer says "10/ page" without a space between the number and the slash.

Environment Info
ng-zorro-antd 8.2.0
Browser Any

I'll try to create a pull request for this soon.
@oestrogen oestrogen changed the title Missing space in pagination size change Missing space in pagination size changer Aug 21, 2019
@oestrogen oestrogen mentioned this issue Aug 21, 2019
Merged
3 tasks
vthinkxie pushed a commit that referenced this issue Oct 12, 2019
@oestrogen @vthinkxie
fix(module:pagination): add space between page size and slash (#4038) (…
b1bba9e 
…#4039)
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this issue Apr 9, 2020
@oestrogen @Ricbet
fix(module:pagination): add space between page size and slash (NG-ZOR…
56ec628 
…RO#4038) (NG-ZORRO#4039)
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this issue Aug 5, 2020
@oestrogen @vthinkxie
fix(module:pagination): add space between page size and slash (NG-ZOR…
322e7d0 
…RO#4038) (NG-ZORRO#4039)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vthinkxie vthinkxie

Labels
Component: Pagination
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oestrogen @vthinkxie