-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:timeline): add gray as a default color #3922
Conversation
Deploy preview for ng-zorro-master ready! Built with commit 2424f14 |
Codecov Report
@@ Coverage Diff @@
## master #3922 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 777 777
Lines 14825 14825
Branches 1910 1910
=======================================
Hits 14128 14128
Misses 260 260
Partials 437 437
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看上去多了一些奇怪的文件
Oh, fuck vim! |
@wendzhue @hsuanxyz Looks like you have used both "grey" and "gray" - only one of these should be used. |
Hi! Thank you for pointing that out. We have changed all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test failed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR Checklist
Please check if your PR fulfills the following requirements:
Tests for the changes have been added (for bug fixes / features)Not neededPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
It works with the latest style update #3921.