-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:message): fix container instance not destroyed in HMR #3859
Conversation
@cipchk You can try to build from this PR and run it with your demo. It should work now. |
@wendzhue Yes, already working in HMR mode (includes other projects). |
Codecov Report
@@ Coverage Diff @@
## master #3859 +/- ##
==========================================
- Coverage 95.36% 95.24% -0.13%
==========================================
Files 723 727 +4
Lines 14722 14694 -28
Branches 1937 1914 -23
==========================================
- Hits 14040 13995 -45
- Misses 249 260 +11
- Partials 433 439 +6
Continue to review full report at Codecov.
|
Deploy preview for ng-zorro-master ready! Built with commit 966e368 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
close #3845
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3845
What is the new behavior?
Does this PR introduce a breaking change?
Other information