Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:descriptions): fix changes to inputs of children not working #3798

Merged
merged 4 commits into from
Jul 16, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Jul 15, 2019

close #3795

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #3795

What is the new behavior?

Changes to the inputs of nz-description-item would be updated.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jul 15, 2019

Deploy preview for ng-zorro-master ready!

Built with commit c115b7a

https://deploy-preview-3798--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #3798 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #3798      +/-   ##
=========================================
+ Coverage   95.35%   95.4%   +0.04%     
=========================================
  Files         706     706              
  Lines       14558   14570      +12     
  Branches     1923    1923              
=========================================
+ Hits        13882   13900      +18     
+ Misses        246     243       -3     
+ Partials      430     427       -3
Impacted Files Coverage Δ
...nts/descriptions/nz-descriptions-item.component.ts 100% <100%> (ø) ⬆️
...mponents/descriptions/nz-descriptions.component.ts 98.7% <100%> (+2.92%) ⬆️
components/core/util/measure-scrollbar.ts 88% <0%> (+16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f1e09c...c115b7a. Read the comment docs.

@wzhudev wzhudev force-pushed the fix-description-input-change branch from 8fc1330 to 77b5d19 Compare July 16, 2019 07:01
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzhudev wzhudev merged commit 3c65697 into NG-ZORRO:master Jul 16, 2019
@wzhudev wzhudev deleted the fix-description-input-change branch July 18, 2019 07:24
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
…ng (NG-ZORRO#3798)

* fix(module:descriptions): fix changes to inputs of children not working

close NG-ZORRO#3795

* docs: fix API name

* fix: merge events

* docs: fix api
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…ng (NG-ZORRO#3798)

* fix(module:descriptions): fix changes to inputs of children not working

close NG-ZORRO#3795

* docs: fix API name

* fix: merge events

* docs: fix api
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nz-description-item [nzTitle] doesn't detect changes properly
2 participants