fix(module:table): fix sortChange with dynamic columns (#3603) #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sortChange() called multiple times after columns changed
|
Deploy preview for ng-zorro-master ready! Built with commit bbc48fa |
Codecov Report
@@ Coverage Diff @@
## master #3605 +/- ##
=======================================
Coverage 95.74% 95.74%
=======================================
Files 689 689
Lines 13705 13705
Branches 1821 1821
=======================================
Hits 13122 13122
Misses 195 195
Partials 388 388
Continue to review full report at Codecov.
|
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Jun 21, 2019
* chore: sync ant-design v3.19.6 (NG-ZORRO#3602) * fix(module:table): fix sortChange with dynamic columns (NG-ZORRO#3603) (NG-ZORRO#3605) close NG-ZORRO#3603 * chore: sync with antd 3.19 (NG-ZORRO#3590) * chore: sync with antd 3.19 * test(module:page-header): fix test * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * build: refactor scripts ref NG-ZORRO#2474 * chore: update ci config * ci: fix integration * ci: add travis_wait * ci: fix ci * ci: fix ci * ci: fix ci * ci: fix ci * ci: fix ci * chore: fix type * build: add site release scripts * build: _ * build: add `test:watch` task * build: fix `test:watch` task * chore: bump node to 12.1.0 * ci: add now.json
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Jun 21, 2019
* chore: sync ant-design v3.19.6 (NG-ZORRO#3602) * fix(module:table): fix sortChange with dynamic columns (NG-ZORRO#3603) (NG-ZORRO#3605) close NG-ZORRO#3603 * chore: sync with antd 3.19 (NG-ZORRO#3590) * chore: sync with antd 3.19 * test(module:page-header): fix test * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * build: refactor scripts ref NG-ZORRO#2474 * chore: update ci config * ci: fix integration * ci: add travis_wait * ci: fix ci * ci: fix ci * ci: fix ci * ci: fix ci * ci: fix ci * chore: fix type * build: add site release scripts * build: _ * build: add `test:watch` task * build: fix `test:watch` task * chore: bump node to 12.1.0 * ci: add now.json
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Jun 21, 2019
* chore: sync ant-design v3.19.6 (NG-ZORRO#3602) * fix(module:table): fix sortChange with dynamic columns (NG-ZORRO#3603) (NG-ZORRO#3605) close NG-ZORRO#3603 * chore: sync with antd 3.19 (NG-ZORRO#3590) * chore: sync with antd 3.19 * test(module:page-header): fix test * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * chore: refactor commit hook (NG-ZORRO#3610) * chore: refactor commit hook * chore(packaging): clean dependencie * chore(packaging): clean dev dependencie * build: refactor scripts ref NG-ZORRO#2474 * chore: update ci config * ci: fix integration * ci: add travis_wait * ci: fix ci * ci: fix ci * ci: fix ci * ci: fix ci * ci: fix ci * chore: fix type * build: add site release scripts * build: _ * build: add `test:watch` task * build: fix `test:watch` task * chore: bump node to 12.1.0 * ci: add now.json * ci: add now.json
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sortChange() called multiple times after columns changed
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3603
What is the new behavior?
Fixes #3603
Does this PR introduce a breaking change?
Other information