Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:avatar): add nzSrcSet & nzAlt properites #3583

Merged
merged 17 commits into from
Jun 21, 2019
Merged

feat(module:avatar): add nzSrcSet & nzAlt properites #3583

merged 17 commits into from
Jun 21, 2019

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Jun 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

cipchk and others added 17 commits December 8, 2018 16:41
chore: merge master

Co-authored-by: Wendell <[email protected]>
Co-authored-by: vthinkxie <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: Wilson Zeng <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: Ekko <[email protected]>
Co-authored-by: null <[email protected]>
chore: merge master

Co-authored-by: vthinkxie <[email protected]>
Co-authored-by: Wendell <[email protected]>
Co-authored-by: Wilson Zeng <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by: GQ <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: simplejason <[email protected]>
Co-authored-by: null <[email protected]>
chore: merge master

Co-authored-by: Wendell <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: vthinkxie <[email protected]>
Co-authored-by: Freax <[email protected]>
chore: merge master

Co-authored-by: Wendell <[email protected]>
Co-authored-by: Rasheed Rahman <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: simplejason <[email protected]>
chore: merge master

Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by: Ethan Zhao <[email protected]>
Co-authored-by: Wendell <[email protected]>
chore: merge master

Co-authored-by:  <[email protected]>
Co-authored-by:  <[email protected]>
chore: merge master

Co-authored-by: Ekko <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by: simplejason <[email protected]>
Co-authored-by: Guillem Palomar <[email protected]>
Co-authored-by: Nickbing Lao <[email protected]>
Co-authored-by: vthinkxie <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: Sunny Liu <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: Wendell <[email protected]>
chore: merge master

Co-authored-by:  <[email protected]>
Co-authored-by: vthinkxie <[email protected]>
Co-authored-by: Wendell <[email protected]>
Co-authored-by: 雪狼 <[email protected]>
Co-authored-by: simplejason <[email protected]>
Co-authored-by:  <[email protected]>
Co-authored-by: olive.wang <[email protected]>
Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by:  <[email protected]>
chore: merge master

Co-authored-by: Hsuan Lee <[email protected]>
Co-authored-by: JerryHong <[email protected]>
Co-authored-by: Wendell <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: Wenqi <[email protected]>
Co-authored-by: Joshua Harris <[email protected]>
Co-authored-by: Gleb Mikheev <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: simplejason <[email protected]>
Co-authored-by: ivan <[email protected]>
Co-authored-by: null <[email protected]>
Co-authored-by: vthinkxie <[email protected]>
- support custom unit in image avatar, close #3543
@netlify
Copy link

netlify bot commented Jun 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 9da520d

https://deploy-preview-3583--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #3583 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3583      +/-   ##
==========================================
+ Coverage   95.72%   95.72%   +<.01%     
==========================================
  Files         690      690              
  Lines       13708    13709       +1     
  Branches     1824     1824              
==========================================
+ Hits        13122    13123       +1     
  Misses        198      198              
  Partials      388      388
Impacted Files Coverage Δ
components/avatar/nz-avatar.component.ts 98.57% <100%> (+0.02%) ⬆️
components/select/nz-option-container.component.ts 95.34% <0%> (-2.33%) ⬇️
components/time-picker/time-holder.ts 97.26% <0%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42daeba...9da520d. Read the comment docs.

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit d0ad5e8 into NG-ZORRO:master Jun 21, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* feat(module:avatar): add nzSrcSet & nzAlt properites
- support custom unit in image avatar, close NG-ZORRO#3543

* chore: add docs
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* feat(module:avatar): add nzSrcSet & nzAlt properites
- support custom unit in image avatar, close NG-ZORRO#3543

* chore: add docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avatar size does not accept units other than pixels
2 participants