Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:form): fix form control template driven #3305

Merged
merged 1 commit into from
Apr 19, 2019
Merged

fix(module:form): fix form control template driven #3305

merged 1 commit into from
Apr 19, 2019

Conversation

vthinkxie
Copy link
Member

close #3211

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Apr 18, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 7051b4d

https://deploy-preview-3305--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Apr 18, 2019

Codecov Report

Merging #3305 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3305      +/-   ##
==========================================
+ Coverage   97.51%   97.52%   +<.01%     
==========================================
  Files         562      562              
  Lines       11852    11857       +5     
  Branches      866      867       +1     
==========================================
+ Hits        11558    11563       +5     
  Misses        183      183              
  Partials      111      111
Impacted Files Coverage Δ
components/form/nz-form-control.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b4bde4...7051b4d. Read the comment docs.

@vthinkxie vthinkxie merged commit 032d193 into NG-ZORRO:master Apr 19, 2019
andrew-yangy pushed a commit to andrew-yangy/ng-zorro-antd that referenced this pull request Jun 20, 2019
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

从1.8升级到7.2后,模板驱动表单验证, 验证错误的时候has-error样式丢失
1 participant