feat(module:typography): add typography component #3119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit 2c06ca9 |
Codecov Report
@@ Coverage Diff @@
## master #3119 +/- ##
==========================================
- Coverage 95.43% 95.42% -0.02%
==========================================
Files 686 698 +12
Lines 14091 14482 +391
Branches 1877 1913 +36
==========================================
+ Hits 13448 13819 +371
- Misses 229 237 +8
- Partials 414 426 +12
Continue to review full report at Codecov.
|
vthinkxie
reviewed
Jun 26, 2019
vthinkxie
reviewed
Jun 26, 2019
components/typography/demo/basic.ts
Outdated
| @Component({ | ||
| selector: 'nz-demo-typography-basic', | ||
| template: ` | ||
| <nz-typography> |
There was a problem hiding this comment.
should be <article nz-typography>
vthinkxie
reviewed
Jun 26, 2019
| @Input() nzEllipsisRows = 1; | ||
| @Input() nzType: 'secondary' | 'warning' | 'danger' | undefined; | ||
| @Input() nzCopyText: string | undefined; | ||
| @Output() readonly nzChange = new EventEmitter<string>(); |
There was a problem hiding this comment.
Suggested change
| @Output() readonly nzChange = new EventEmitter<string>(); | |
| @Output() readonly nzContentChange = new EventEmitter<string>(); |
vthinkxie
reviewed
Jun 26, 2019
| @Input() nzCopyText: string | undefined; | ||
| @Output() readonly nzChange = new EventEmitter<string>(); | ||
| @Output() readonly nzCopy = new EventEmitter<string>(); | ||
| @Output() readonly nzExpand = new EventEmitter<void>(); |
There was a problem hiding this comment.
Suggested change
| @Output() readonly nzExpand = new EventEmitter<void>(); | |
| @Output() readonly nzExpandChange = new EventEmitter<void>(); |
Co-Authored-By: vthinkxie <[email protected]>
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:typography): add typography component * test(module:typography): add test * style: fix lint * docs: add static path * test(module:typography): add test * docs: fix API * test(module:typography): fix ci test * test(module:typography): fix ci test * fix(module:typography): fix ellipsis content * Update components/components.less Co-Authored-By: vthinkxie <[email protected]>
hsuanxyz
added a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:typography): add typography component * test(module:typography): add test * style: fix lint * docs: add static path * test(module:typography): add test * docs: fix API * test(module:typography): fix ci test * test(module:typography): fix ci test * fix(module:typography): fix ellipsis content * Update components/components.less Co-Authored-By: vthinkxie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2777
What is the new behavior?
Does this PR introduce a breaking change?
Other information