Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade icon to 2.0.2 #3085

Merged
merged 1 commit into from
Mar 14, 2019
Merged

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Mar 13, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: Update dependency

What is the current behavior?

Issue Number: N/A

What is the new behavior?

This would make the package rely on @ant-design/icons-angular 2.0.2, which would not require TypeScript as a peer dependency. So TypeScript mismatching gets fixed.

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@wzhudev wzhudev requested a review from vthinkxie March 13, 2019 15:09
@codecov
Copy link

codecov bot commented Mar 13, 2019

Codecov Report

Merging #3085 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3085   +/-   ##
=======================================
  Coverage   97.32%   97.32%           
=======================================
  Files         550      550           
  Lines       11510    11510           
  Branches      819      819           
=======================================
  Hits        11202    11202           
  Misses        199      199           
  Partials      109      109

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 494e18f...4ad9dbe. Read the comment docs.

@netlify
Copy link

netlify bot commented Mar 13, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 4ad9dbe

https://deploy-preview-3085--ng-zorro-master.netlify.com

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit fc72d7d into NG-ZORRO:master Mar 14, 2019
@wzhudev wzhudev deleted the icon-upgrade branch March 21, 2019 04:14
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants