Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:tabs): support lazy load tabs #2968

Merged
merged 1 commit into from
Feb 26, 2019
Merged

feat(module:tabs): support lazy load tabs #2968

merged 1 commit into from
Feb 26, 2019

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2716

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Feb 26, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 2ccac87

https://deploy-preview-2968--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Feb 26, 2019

Codecov Report

Merging #2968 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2968      +/-   ##
==========================================
+ Coverage   97.37%   97.37%   +<.01%     
==========================================
  Files         545      546       +1     
  Lines       11260    11266       +6     
  Branches      809      809              
==========================================
+ Hits        10964    10970       +6     
  Misses        188      188              
  Partials      108      108
Impacted Files Coverage Δ
components/tabs/nz-tab.component.ts 100% <100%> (ø) ⬆️
components/tabs/nz-tab.directive.ts 100% <100%> (ø)
components/tabs/nz-tabs.module.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abb9ae4...2ccac87. Read the comment docs.

@vthinkxie vthinkxie merged commit 626a0f4 into NG-ZORRO:master Feb 26, 2019
@vthinkxie vthinkxie deleted the lazy-tab branch February 26, 2019 07:07
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant