Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tooptip): fix setTitle proxy to nzTitle #2698

Merged
merged 2 commits into from
Jan 24, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Dec 27, 2018

close #2695, #2800

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2695, #2800

What is the new behavior?

setTitle is proxy to nzTitle, so nzTitle of nzTooltipCopmonent is updated.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Dec 27, 2018

Deploy preview for ng-zorro-master ready!

Built with commit ca0c05a

https://deploy-preview-2698--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Dec 27, 2018

Codecov Report

Merging #2698 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2698      +/-   ##
==========================================
+ Coverage   95.51%   95.53%   +0.01%     
==========================================
  Files         518      517       -1     
  Lines       12292    12264      -28     
  Branches     1697     1692       -5     
==========================================
- Hits        11741    11716      -25     
+ Misses        191      189       -2     
+ Partials      360      359       -1
Impacted Files Coverage Δ
components/tooltip/nz-tooltip.component.ts 95.65% <100%> (+0.19%) ⬆️
components/popover/nz-popover.component.ts 100% <100%> (ø) ⬆️
components/tooltip/nz-tooltip.directive.ts 96.55% <100%> (+0.12%) ⬆️
components/core/util/convert.ts 82.6% <0%> (-3.11%) ⬇️
components/icon/public-api.ts
components/icon/index.ts
components/icon/nz-icon-test.module.ts 100% <0%> (ø)
components/icon/nz-icon.service.ts 98.27% <0%> (+0.06%) ⬆️
components/pagination/nz-pagination.component.ts 100% <0%> (+0.69%) ⬆️
components/icon/nz-icon.directive.ts 96.29% <0%> (+3.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c41715...ca0c05a. Read the comment docs.

@CarterLi
Copy link

module:tooltip

Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit e17798d into NG-ZORRO:master Jan 24, 2019
vthinkxie pushed a commit that referenced this pull request Jan 24, 2019
@wzhudev wzhudev deleted the fix-tooltip branch January 24, 2019 04:16
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip in Menu component is not work
5 participants