Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:menu): fix fold menu #2454

Merged
merged 2 commits into from
Nov 24, 2018
Merged

fix(module:menu): fix fold menu #2454

merged 2 commits into from
Nov 24, 2018

Conversation

dulinxi
Copy link
Contributor

@dulinxi dulinxi commented Nov 14, 2018

fix accidentally closed submenu bug
close #2449

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #2454 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2454   +/-   ##
=======================================
  Coverage   95.84%   95.84%           
=======================================
  Files         485      485           
  Lines       12302    12302           
  Branches     1672     1672           
=======================================
  Hits        11791    11791           
  Misses        150      150           
  Partials      361      361

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d9db523...6cbc64f. Read the comment docs.

@dulinxi
Copy link
Contributor Author

dulinxi commented Nov 15, 2018

I saw the problem. But I just modify the file 'componenet/menu/nz-submenu.component.html' why it impact the file 'components/time-picker/time-holder.ts'.

chore: update styles(ant-design 3.10.7) (#2432)
@vthinkxie vthinkxie merged commit e41640a into NG-ZORRO:master Nov 24, 2018
vthinkxie added a commit that referenced this pull request Nov 30, 2018
* docs: update NG-ZORRO logo (#2425)

* fix(module:collapse): can't fold up active panel with accordion (#2440)

close #2437

* chore: update styles(ant-design 3.10.7) (#2432)

* chore: update styles(ant-design 3.10.8) (#2475)

* feat: Adds danish locale (#2486)

close #2485

* fix(module:menu): fix dropdown menu item selected className (#2434)

close #2433

* fix(module:list): fix invalid render empty style when unspecified data source (#2415)

close #2385

* docs(module:modal): add missing nzClassName property (#2400)

* docs: add faq in icons docs (#2459)

* fix(module:menu): fix fold menu (#2454)

close #2449

* refactor(module:all): use cdk keycodes instead of magic number (#2499)

* release(1.8.1): release 1.8.1 (#2523)

* chore: update styles(ant-design 3.10.9) (#2525)

* fix(readme): fix misspelling (#2472)

* refactor(module:all): support Angular 7.0 (#2372)

* refactor(module:all): refactor component to support onPush & SSR

* refactor(module:badge): refactor badge

* refactor(module:button & card): refactor

* test(module:button): fix test case

* fix(module:avatar): fix avatar

* fix(module:tree): fix tree tslint

* fix(module:tree): fix tree module

* fix(module:all): fix tslint config

* refactor(module:all): upgrade to angular 7.0

* fix(module:all): fix typescript error

* fix(module:build): fix build less options

* fix(module:integration): fix webpack test

* build: rm unused package

* build: fix build & ci

* test(module:spin): fix test error

* docs: update readme

*  refactor(module:checkbox): support checkbox onPush (#2478)

* docs: update NG-ZORRO logo (#2425)

* fix(module:collapse): can't fold up active panel with accordion (#2440)

close #2437

* chore: update styles(ant-design 3.10.7) (#2432)

* refactor(module:checkbox): support checkbox onPush

* refactor(module:collapse): support onPush in collapse (#2481)

*  refactor(module:divider): refactor divider (#2482)

ref #2381

* refactor(module:form): refactor form (#2493)

* refactor(module:grid): refactor grid module (#2498)

* refactor(module:layout): refactor layout (#2500)

* feat(module:progress): support custom strokeColor and strokeLinecap (#2404)

close #2378

* feat(module:avatar): support custom size (#2416)

close #2380

* fix(module:timeline): fix loading icon (#2386)

close #2377

* feat(module:drawer): add input property in NzDrawerRef (#2464)

close #2403

* refactor(module:radio): refactor radio to support OnPush (#2519)

* refactor(module:spin): refactor spin (#2530)

* refactor(module:alert & card): refactor card & refactor template outlet (#2532)

* refactor(module:switch & checkbox): refactor switch & checkbox (#2533)

* refactor(module:core): refactor input convert decorators (#2535)

ref #2474

* refactor(module:mention): refactor mention (#2510)

ref: #2381

* refactor(module:steps): refactor steps (#2512)

ref #2381

* feat(module:modal): support clicking ESC to close modal (#2483)

close #1999

* refactor(module:breadcrumb): refactor breadcrumb (#2513)

ref #2381

* refactor(module:skeleton): refactor skeleton (#2514)

ref #2381

* refactor(module:icon): refactor icon (#2517)

ref #2381

* refactor(module:tree-select): refactor tree-select (#2528)

ref: #2381

* build: bump webpack integration (#2524)

build: bump webpack integration

* refactor(module:timeline): refactor timeline (#2515)

close #2379

* support alternate positions, alternate and right alternate
* support reversing

* refactor(module:autocomplete): refactor autocomplete (#2505)

ref #2381, close #2420

* refactor(module:cascader): refactor cascader (#2516)

* refactor(module:cascader): refactor cascader

close #2935
ref #2198

* fix(module:cascader): fix isFocused access

* refactor(module:avatar): refactor avatar (#2536)

* fix(module:avatar): fix text style

* refactor(module:avatar): refactor avatar

ref: #2381

* refactor(module:upload): refactor upload (#2555)

* refactor(module:upload): refactor upload

- feat: add `nzOpenFileDialogOnClick` prop to allow setting whether to open the upload dialog when the component is clicked

* chore: add encapsulation:ViewEncapsulation.None
ref #2381

* refactor(module:list): refactor list (#2548)

* refactor(module:list): refactor list

* fix: import scrolling in share module

* chore: add encapsulation:ViewEncapsulation.None
ref #2381

* refactor(module:transfer): refactor transfer (#2553)

* refactor(module:transfer): refactor transfer

- feat: add nzDisabled property
- need verify design details, ant-design/ant-design#13330

* chore: search muse be disabled

* chore: add encapsulation:ViewEncapsulation.None

ref #2381

* refactor(module:back-top): refactor back-top (#2547)

refactor(module:back-top): refactor back-top

* refactor(module:anchor): refactor anchor (#2546)

* refactor(module:anchor): refactor anchor

- feat: the nzTarget support string value
- fix: invalid id in demo

* chore: add encapsulation:ViewEncapsulation.None

* chore: add encapsulation:ViewEncapsulation.None

* chore: fix display style in host

* chore: remove :host

ref #2381

* refactor(module:affix): refactor affix (#2544)

* refactor(module:affix): refactor affix

- the nzTarget support string value

* fix: release

* style: removed no-any in first line

* fix: fix style

* chore: fix test

* chore: fix display style in host

* chore: remove :host
vthinkxie pushed a commit that referenced this pull request Nov 30, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

收缩菜单在收缩时,鼠标移到子菜单的空隙部分会导致子菜单关闭
3 participants