Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:upload): optimize invalid parameter warning #2363

Merged
merged 22 commits into from
Oct 26, 2018
Merged

perf(module:upload): optimize invalid parameter warning #2363

merged 22 commits into from
Oct 26, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Oct 26, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2322

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 26, 2018

Codecov Report

Merging #2363 into master will decrease coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2363      +/-   ##
==========================================
- Coverage   95.86%   95.83%   -0.04%     
==========================================
  Files         485      485              
  Lines       12241    12289      +48     
  Branches     1656     1671      +15     
==========================================
+ Hits        11735    11777      +42     
- Misses        149      151       +2     
- Partials      357      361       +4
Impacted Files Coverage Δ
components/upload/nz-upload-btn.component.ts 98.11% <100%> (+0.03%) ⬆️
components/tree/nz-tree.component.ts 95.12% <0%> (-3.36%) ⬇️
components/icon/nz-icon.service.ts 95.74% <0%> (-1.4%) ⬇️
components/tree/nz-tree-node.component.ts 95.3% <0%> (-1%) ⬇️
components/tree/nz-tree.service.ts 94.07% <0%> (+0.39%) ⬆️
components/table/nz-table.component.ts 96.66% <0%> (+1.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e06b9a7...8e1cc81. Read the comment docs.

@vthinkxie vthinkxie merged commit ee31a4e into NG-ZORRO:master Oct 26, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants