Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:esm5): fix esm5 package #2357

Merged
merged 3 commits into from
Oct 26, 2018
Merged

fix(module:esm5): fix esm5 package #2357

merged 3 commits into from
Oct 26, 2018

Conversation

vthinkxie
Copy link
Member

close #2339

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 25, 2018

Codecov Report

Merging #2357 into master will increase coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
+ Coverage   95.86%   95.86%   +<.01%     
==========================================
  Files         485      485              
  Lines       12228    12241      +13     
  Branches     1644     1656      +12     
==========================================
+ Hits        11722    11735      +13     
  Misses        149      149              
  Partials      357      357
Impacted Files Coverage Δ
...ponents/date-picker/date-range-picker.component.ts 86.53% <ø> (-0.5%) ⬇️
...mponents/carousel/nz-carousel-content.directive.ts 100% <100%> (ø) ⬆️
components/grid/nz-col.directive.ts 100% <100%> (ø) ⬆️
components/grid/nz-col.component.ts 100% <100%> (ø) ⬆️
components/spin/nz-spin.component.ts 100% <100%> (ø) ⬆️
components/grid/nz-row.directive.ts 100% <100%> (ø) ⬆️
components/steps/nz-step.component.ts 94.64% <100%> (ø) ⬆️
components/form/nz-form-label.component.ts 100% <100%> (ø) ⬆️
components/input/nz-input.directive.ts 96.29% <100%> (ø) ⬆️
components/table/nz-th.component.ts 99.34% <100%> (ø) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7906066...9e1d36d. Read the comment docs.

@vthinkxie vthinkxie merged commit e06b9a7 into NG-ZORRO:master Oct 26, 2018
@vthinkxie vthinkxie deleted the fix-esm5 branch February 26, 2019 07:08
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:esm5): fix esm5 package
close NG-ZORRO#2339

* refactor(module:all): refactor all constructor

* fix(module:esm5): fix esm5 error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant