Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:icon): fix icon miss in components #2321

Merged
merged 2 commits into from
Oct 23, 2018
Merged

fix(module:icon): fix icon miss in components #2321

merged 2 commits into from
Oct 23, 2018

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev
Copy link
Member

wzhudev commented Oct 22, 2018

NzIconModule should be imported into NzLayoutModule, which I am going to fix already fixed in #2325. May result in conflict.

@codecov
Copy link

codecov bot commented Oct 22, 2018

Codecov Report

Merging #2321 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2321      +/-   ##
==========================================
+ Coverage   95.85%   95.85%   +<.01%     
==========================================
  Files         485      485              
  Lines       12213    12215       +2     
  Branches     1646     1647       +1     
==========================================
+ Hits        11707    11709       +2     
  Misses        148      148              
  Partials      358      358
Impacted Files Coverage Δ
components/menu/demo/inline-collapsed.ts 83.33% <ø> (ø) ⬆️
components/layout/demo/custom-trigger.ts 100% <ø> (ø) ⬆️
components/dropdown/nz-dropdown.directive.ts 100% <100%> (ø) ⬆️
components/popover/nz-popover.component.ts 100% <100%> (ø) ⬆️
components/select/nz-option-li.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7beda8...4fbd4c0. Read the comment docs.

@vthinkxie vthinkxie merged commit af4ddfb into NG-ZORRO:master Oct 23, 2018
@vthinkxie vthinkxie deleted the fix-icon branch February 26, 2019 07:08
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:icon): fix icon miss in components

* fix(module:icon): fix table icon
close NG-ZORRO#2326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants