Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(module:list): fix does not trigger change detection correctly when from empty array to data array #2199

Merged
merged 20 commits into from
Oct 6, 2018
Merged

fix(module:list): fix does not trigger change detection correctly when from empty array to data array #2199

merged 20 commits into from
Oct 6, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Sep 27, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1819

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@cipchk
Merge pull request #1 from NG-ZORRO/master
16bad67 
upgrade laster version
@cipchk
Merge pull request #2 from NG-ZORRO/master
87bfc95 
upgrade
@cipchk
Merge pull request #3 from NG-ZORRO/master
477168e 
upgrade
@cipchk
Merge pull request #4 from NG-ZORRO/master
eb538c3 
latest version
@cipchk
Merge pull request #5 from NG-ZORRO/master
c469a1b 
laster
@cipchk
Merge pull request #6 from NG-ZORRO/master
dee2127 
latest
@cipchk
Merge pull request #7 from NG-ZORRO/master
13f290d 
lastest
@cipchk
Merge pull request #8 from NG-ZORRO/master
71958d5 
lastest
@cipchk
Merge pull request #9 from NG-ZORRO/master
d9e0160 
upgrade
@cipchk
Merge pull request #10 from NG-ZORRO/master
3195ecc 
upgrade
@cipchk
Merge pull request #11 from NG-ZORRO/master
a8c0895 
upgrade
@cipchk
Merge pull request #12 from NG-ZORRO/master
50d725c 
upgrade
@cipchk
Merge pull request #13 from NG-ZORRO/master
5b7d443 
upgrade
@cipchk
Merge pull request #14 from NG-ZORRO/master
b447837 
merge
@cipchk
Merge pull request #15 from NG-ZORRO/master
5d76294 
upgrade
@cipchk
Merge pull request #16 from NG-ZORRO/master
1b5705d 
upgrade latest
@cipchk
Merge pull request #17 from NG-ZORRO/master
cc4aafc 
upgrade
@cipchk
Merge pull request #18 from NG-ZORRO/master
de43ada 
lastest
@cipchk
fix(module:list): fix does not trigger change detection correctly whe…
5627af4 
…n from empty array to data array
@codecov
Copy link

codecov bot commented Sep 27, 2018 •
edited
Loading

Codecov Report

Merging #2199 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2199      +/-   ##
==========================================
- Coverage   95.96%   95.96%   -0.01%     
==========================================
  Files         482      482              
  Lines       11965    11956       -9     
  Branches     1594     1594              
==========================================
- Hits        11482    11473       -9     
  Misses        134      134              
  Partials      349      349
Impacted Files Coverage Δ
components/list/nz-list.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95954cc...f981cd6. Read the comment docs.

wilsoncook
wilsoncook requested changes Oct 6, 2018
View reviewed changes
components/list/nz-list.component.ts Outdated
this._setClassMap();
// Delayed detection refresh limited by nz-spin (issesus (#11280)[https://github.com/angular/material2/issues/11280) )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"issesus" misspelled, fixed it to allow merge

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And "[https://github.com/angular/components/issues/11280)" tobe "[https://github.com/angular/components/issues/11280]"

wilsoncook
wilsoncook requested changes Oct 6, 2018
View reviewed changes
components/list/nz-list.component.ts Outdated
this._setClassMap();
// Delayed detection refresh limited by nz-spin (issesus (#11280)[https://github.com/angular/material2/issues/11280) )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And "[https://github.com/angular/components/issues/11280)" tobe "[https://github.com/angular/components/issues/11280]"

@wilsoncook
Copy link
Member

Good job @cipchk

@wilsoncook wilsoncook merged commit 92c1a85 into NG-ZORRO:master Oct 6, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
@cipchk @wilsoncook
fix(module:list): fix does not trigger change detection correctly whe…
d3ce82b 
…n from empty array to data array (NG-ZORRO#2199)

* fix(module:list): fix does not trigger change detection correctly when from empty array to data array

* fix document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilsoncook wilsoncook wilsoncook approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cipchk @wilsoncook