Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:drawer): support top and bottom placement #2039

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2015

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

⌛️ ant-design 3.9.0

@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #2039 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2039      +/-   ##
==========================================
+ Coverage   96.01%   96.02%   +<.01%     
==========================================
  Files         470      470              
  Lines       11424    11436      +12     
  Branches     1515     1519       +4     
==========================================
+ Hits        10969    10981      +12     
  Misses        131      131              
  Partials      324      324
Impacted Files Coverage Δ
components/core/util/convert.ts 88.88% <100%> (+1.38%) ⬆️
components/drawer/nz-drawer.component.ts 97.26% <100%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69e1f5f...6b5ad23. Read the comment docs.

@simplejason simplejason merged commit 693b4eb into NG-ZORRO:master Sep 7, 2018
hsuanxyz added a commit that referenced this pull request Sep 10, 2018
@hsuanxyz hsuanxyz deleted the drawer/feat-placement branch October 23, 2018 10:35
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants