Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for RTL #1762

Closed
KhaledSMQ opened this issue Jun 30, 2018 · 10 comments
Closed

Adding support for RTL #1762

KhaledSMQ opened this issue Jun 30, 2018 · 10 comments
Assignees
Labels
help wanted 💬 Discussion Need more insights to this issue
Milestone

Comments

@KhaledSMQ
Copy link

What problem does this feature solve?

Currently i tried to add RTL support for temporary solution till ant.design release official support for the components. please feel free to check my modified fork
https://github.com/KhaledSMQ/ng-zorro-antd

What does the proposed API look like?

Add RTL Components

@KhaledSMQ
Copy link
Author

related to ant-design/ant-design#4051

@mehdiraized
Copy link

+1

@vthinkxie vthinkxie mentioned this issue Feb 19, 2019
12 tasks
@vthinkxie vthinkxie self-assigned this Feb 24, 2019
@ImMo3
Copy link

ImMo3 commented Apr 27, 2019

Is there any update ?
@vthinkxie

@CoderBees245
Copy link

@saeedrahimi
Copy link
Contributor

saeedrahimi commented Jul 30, 2019

Currently we are working on a RTL fork of this repository in our company and we made some of components work with right-to-left direction.
I want to contribute and i don't know how to start.
I've already read the Guide.
We add rtl styles to components one by one and at the beginning i want to pull request button component.
Do i need to open an issue per component?

@vthinkxie
Copy link
Member

vthinkxie commented Jul 30, 2019

Hi @saeedrahimi
I saw your pr https://github.com/NG-ZORRO/ng-zorro-antd/pull/3882/files great job

There are two things we must take into consideration

  1. all styles file are following ant design repo
    there is a discuss here and here
  2. we replace moment with date-fns since version 0.7.x because moment is not treeshake-able

maybe you can submit a pr to ant-design repo first, so we can sync from them.
thanks a lot!

@wzhudev
Copy link
Member

wzhudev commented Jan 3, 2020

@saeedrahimi I noticed that you finished the work of ant-design/ant-design#19380. Great job! Could you please bring RTL to zorro? Many thanks in advance!

@saeedrahimi
Copy link
Contributor

saeedrahimi commented Jan 3, 2020

@saeedrahimi I noticed that you finished the work of ant-design/ant-design#19380. Great job! Could you please bring RTL to zorro? Many thanks in advance!

RTL of Ant Design in react will be shipping out with v4 release. I there any plan to sync with new release? there are a lot of changes.
I think it needs to discuss after v4 release and syncing zorro with v4.

@wzhudev wzhudev added the 💬 Discussion Need more insights to this issue label Jan 3, 2020
@wzhudev
Copy link
Member

wzhudev commented Jan 3, 2020

@saeedrahimi We're working on ng-zorro-antd 9.0.0 and will sync antd 4.0.0 in this version. So feel free to submit PR.

@saeedrahimi
Copy link
Contributor

#4704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted 💬 Discussion Need more insights to this issue
Projects
None yet
Development

No branches or pull requests

8 participants