Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix select zero value & scroll bug #1299

Merged
merged 1 commit into from
Apr 11, 2018
Merged

fix(module:select): fix select zero value & scroll bug #1299

merged 1 commit into from
Apr 11, 2018

Conversation

vthinkxie
Copy link
Member

close #1229 close #1245

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #1299 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1299      +/-   ##
==========================================
- Coverage   97.26%   97.25%   -0.02%     
==========================================
  Files         191      191              
  Lines        7926     7929       +3     
  Branches     1041     1041              
==========================================
+ Hits         7709     7711       +2     
  Misses         25       25              
- Partials      192      193       +1
Impacted Files Coverage Δ
components/select/nz-option-li.component.ts 100% <100%> (ø) ⬆️
...mponents/select/nz-select-top-control.component.ts 97.72% <100%> (+0.02%) ⬆️
components/select/nz-option-container.component.ts 91.87% <100%> (+0.05%) ⬆️
components/table/nz-table.component.ts 94.19% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b9c39...2e1bf69. Read the comment docs.

@vthinkxie vthinkxie merged commit 0552141 into NG-ZORRO:master Apr 11, 2018
@vthinkxie vthinkxie deleted the fix-select-scroll branch October 10, 2018 02:49
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant