Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): provide open & close & setConfirmLoading function #125

Merged
merged 1 commit into from
Aug 31, 2017
Merged

feat(module:modal): provide open & close & setConfirmLoading function #125

merged 1 commit into from
Aug 31, 2017

Conversation

giscafer
Copy link
Contributor

use #modal.open() instead of set nzVisible=true
use #modal.close() instead of set nzVisible=false
use #modal.setConfirmLoading(loading:boolean) instead of set confirmLoading

close #118

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

use #modal.open() instead of set nzVisible=true
use #modal.close() instead of set nzVisible=false
use #modal.setConfirmLoading(loading:boolean) instead of set confirmLoading

close #118
@coveralls
Copy link

Coverage Status

Coverage remained the same at 52.233% when pulling 534b329 on giscafer:modal-open-close-loading into 81cbae9 on NG-ZORRO:master.

@vthinkxie
Copy link
Member

please update the doc as well. thanks

@vthinkxie vthinkxie merged commit 0f87f6c into NG-ZORRO:master Aug 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modal组件功能建议(open() and close() for Modal)
3 participants