feat(module:popover): support OnPush

change binding name change showcases’ changeDetection to OnPush
NG-ZORRO · Aug 27, 2017 · d5d5293 · d5d5293
1 parent 1fb8d6e
commit d5d5293
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/components/popover/nz-popover.component.ts b/src/components/popover/nz-popover.component.ts
@@ -23,8 +23,8 @@ import { NzToolTipComponent } from '../tooltip/nz-tooltip.component';
       (detach)="hide()"
       (positionChange)="onPositionChange($event)"
       [positions]="_positions"
-      [open]="nzVisible">
-      <div class="ant-popover" [ngClass]="_classMap" [ngStyle]="nzOverlayStyle" [@fadeAnimation]="''+nzVisible"
+      [open]="visible$ | async">
+      <div class="ant-popover" [ngClass]="_classMap" [ngStyle]="nzOverlayStyle" [@fadeAnimation]="''+(visible$ | async)"
         (@fadeAnimation.done)="_afterVisibilityAnimation($event)">
         <div class="ant-popover-content">
           <div class="ant-popover-arrow"></div>

diff --git a/src/showcase/nz-demo-popover/nz-demo-popover.component.ts b/src/showcase/nz-demo-popover/nz-demo-popover.component.ts
@@ -1,8 +1,9 @@
-import { Component, OnInit, ViewEncapsulation } from '@angular/core';
+import { Component, OnInit, ViewEncapsulation, ChangeDetectionStrategy } from '@angular/core';
 
 @Component({
   selector     : 'nz-demo-popover',
   encapsulation: ViewEncapsulation.None,
+  changeDetection: ChangeDetectionStrategy.OnPush,
   templateUrl  : './nz-demo-popover.html'
 })