Enable Transport Prefixes #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I note that the format is |
scanon
requested changes
Jan 3, 2025
| @@ -206,13 +206,20 @@ def images(ctx, siteconf, image, podman_args, **site_opts): | |||
| @click.argument("podman_args", nargs=-1, type=click.UNPROCESSED) | |||
| @click.argument("image") | |||
| def pull(ctx, siteconf, image, podman_args, **site_opts): | |||
| """Pulls an image to a local repository and makes a squashed copy.""" | |||
| """Pulls an image to a local repository and makes a squashed copy.""" | |||
There was a problem hiding this comment.
Can you fix the trailing whitespaces?
|
|
||
| # Check for transport_prefix | ||
| if "://" in image: | ||
| transport_prefix, image = image.split("://", 1) |
There was a problem hiding this comment.
Since the prefix isn't used, maybe replace this with just
if "://" in image:
image = image.split("://", 1)[0]
| # Check for transport_prefix | ||
| if "://" in image: | ||
| transport_prefix, image = image.split("://", 1) | ||
| else: |
There was a problem hiding this comment.
You can drop the else section since we don't use the transport prefix
|
Thanks for the report and proposed fix. This looks good and this seems a reasonable place to handle it. Can you do a few minor things just to keep the flake8 happy. I'll add a few other minor comments and then we can merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't a
CONTRIB.mdso I have created a fork and PR.Closes #132. TLDR: enables
podman-hpc pull docker://docker.io/library/ubuntu:latest.I thought that simply adding this after the
podman pullsubprocess would do the job instead of updatingMigrateUtils().if proc.returncode == 0:?podman-hpc. If you would accept this change / or have feedback do let me know and I'll do some testing.