Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable minimum number of evolvable pokemon for lucky egg usage #791

Merged
merged 2 commits into from
Jul 27, 2016

Conversation

bjwood
Copy link
Contributor

@bjwood bjwood commented Jul 27, 2016

Ensures that a minimum number of pokemon are ready to be evolved before using a lucky egg. See #632

@maxbrueckl
Copy link

maxbrueckl commented Jul 27, 2016

But maybe we should collect pokemon to evolve up to the number configured, then use egg and evolve all at once.

This means to skip evolving until the number is reached.

@bjwood
Copy link
Contributor Author

bjwood commented Jul 27, 2016

@maxbrueckl That's what this request aims to achieve. If UseLuckyEggsWhileEvolving is set, the actual evolution process gets skipped until we have reached the minimum number defined. Once we hit that amount, it uses an egg and processes all the evolutions at once.

@maxbrueckl
Copy link

Yes, of course. I missed the else branch. my fault, sry

@NecronomiconCoding NecronomiconCoding merged commit 2e0ac93 into NecronomiconCoding:master Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants