[Feature] Added a better config merging system #1874
Conversation
Fixed conflicts and reimplemented: Ignore all pokemon not on Sniper Filter Time for pokestop arrival
So I decided to go through every single setting and supply a default value to each one. If everyone uses this as standard in the future there should be no need to switch out configs, it will simply update the old config with the new default values. IF THIS WORKS, MORE WORK WILL BE NECESSARY TO REMOVE OLD CONFIG REPLACEMENT.
|
I'd really like to have a second opinion on whether my method should be the new standard and whether I should rip out the old implementation. |
|
If you look in Settings.cs in Logic, around line 482 you will see where we apply a bunch of defaults, if you can verify we no longer need these and can use DefaultValue attributes insteads, that would be awesome. |
|
@dddbliss I did what you suggested and it seems to work fine. I think this method may overwrite the need for a lot of the VersionCheckState code (Specifically TransferConfig()) |
# Conflicts: # PoGo.NecroBot.Logic/Settings.cs
|
Do not commit, found an issue with fresh installs. Trying to resolve issue.
|
Previously the default values were not being pushed to a GlobalSettings object and thus would not be used.
Andrerm124
changed the title
|
Let us know when the issue has been resolved. |
|
Already fixed, it's ready for a commit I believe. Unless you can see any issues that is. |
# Conflicts: # PoGo.NecroBot.Logic/Settings.cs
|
@SimplyPHP Could you please commit this request? I'm heading off for the night and won't be able to fix any conflicts that pop up, thanks :) |
[Feature] Added a better config merging system
Fixed conflicts and reimplemented:
Ignore all pokemon not on Sniper Filter
Time for pokestop arrival