-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for refactoring of the logging messages #1731
Merged
NecronomiconCoding
merged 10 commits into
NecronomiconCoding:master
from
igeligel:master
Aug 1, 2016
Merged
Pull request for refactoring of the logging messages #1731
NecronomiconCoding
merged 10 commits into
NecronomiconCoding:master
from
igeligel:master
Aug 1, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix indentation of xml documentation
Edit the access modifiers of the methods to more strict structure
add model for logging strings
Extending the model and fix the typo in transferred
Instantiate the logging model with setting the session and use the Model for the logging part
edit access modifiers to internal for Listen(...) and make the handlers private
Great job. Did anything in the output change or just in the usage/internals? |
Edit naming of event parameters
There were no changes. I made a picture of the current console output. Output strings were not changed but i was close to fix a typo for the transferred string but i do not know any guideline on those strings (like max length). Transferred =
session?.Translation.GetTranslation(
TranslationString.LogEntryTransfered) ?? "TRANSFERED"; Should be written with two r's i believe. If it is allowed ill change it too. |
schnapster
pushed a commit
to schnapster/NecroBot
that referenced
this pull request
Dec 8, 2016
Pull request for refactoring of the logging messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What i have done: