Enhanced Renaming #1431
Merged
Enhanced Renaming #1431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the Bot will snipe until he's out of pokeballs and tell you why he stopped or didn't start. I never worked with CancellationToken so please double check the code.
Added MinPokeballsWhileSnipe which takes place of the old MinPokeballsToSnipe. The Bot will end sniping if you have only inPokeballsWhileSnipe pokeballs left.
1. The bot won't rename favorites. 2. Instead of "RenameAboveIv" you now have "RenamePokemon" which renames all pokemon not transfered and "RenameOnlyAboveIv" which skips pokemon with less than KeepMinIvPercentage IV. With both true you have the old behavior. "RenameOnlyAboveIv" alone will do nothing.
|
perfect, thanks! |
schnapster
pushed a commit
to schnapster/NecroBot
that referenced
this pull request
Dec 8, 2016
…okemon Enhanced Renaming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"RenamePokemon" which renames all pokemon not transfered and
"RenameOnlyAboveIv" which skips pokemon with less than
KeepMinIvPercentage IV.
With both true you have the old behavior.
"RenameOnlyAboveIv" alone will do nothing.
I think it's easier to maintain and extend than #1416