Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove path separator char prepended to profile, as this breaks Path.Combine #1021

Merged
merged 3 commits into from
Jul 27, 2016
Merged

Remove path separator char prepended to profile, as this breaks Path.Combine #1021

merged 3 commits into from
Jul 27, 2016

Conversation

Ilses
Copy link
Contributor

@Ilses Ilses commented Jul 27, 2016

Barely larger than the Eevee typo

@5andr0
Copy link
Contributor

5andr0 commented Jul 27, 2016 •
edited
Loading

Ahh you were faster than me. Can you add this to your commit:
[JsonIgnore] public string ConfigPath;
[JsonIgnore] public string ProfilePath;

Now we have to use Path.Combine in logger aswell: NecroBot\PoGo.NecroBot.CLI\bin\ReleasePtc\Logs

@maximegmd maximegmd merged commit 16ce9f2 into NecronomiconCoding:master Jul 27, 2016
@Ilses Ilses deleted the bugfix-profiles branch July 27, 2016 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ilses @5andr0 @maximegmd