-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/shared types #154
base: main
Are you sure you want to change the base?
Feature/shared types #154
Conversation
@race-of-sloths include |
@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: waiting for scoringWe're waiting for maintainer to score this pull request with What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
…o feature/shared-types
@race-of-sloths score 13 Finding a replacement for the indexer is critical and has been a huge effort. My score is not only for the content in this PR, but also for all the efforts needed to get here. |
@Tguntenaar Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: staleThis pull request was removed from the race, but you can include it again with What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would request a bit more coverage in the migration test. I can see we are adding community and proposals, but not RFP for example. I would also feel safer if we had tests on editing RFPs / Proposal after migration.
Thanks for the review and comments! Before making further edits to this PR, I think we should discuss how we want to manage this shared folder as a team. For now, the crate is sufficient, so we can proceed with the API. We can revisit type management once we’ve replaced the indexer on the frontend. |
I came across this message in the NEAR Dev Community: https://t.me/neardev/58522 . I thought it might add some value to discussions in this PR. |
❌ PR inactiveThis PR has been inactive for two weeks. It's now marked as stale. Tip If you think it's a mistake, you can restart the bot with |
@@ -0,0 +1,476 @@ | |||
# This file is automatically @generated by Cargo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Tguntenaar suggest adding this crate to members of wokspace https://github.com/NEAR-DevHub/neardevhub-contract/blob/main/Cargo.toml#L2, so that it doesn't introduce a Cargo.lock
of its own
repository = "https://github.com/neardevhub/neardevhub-contract" | ||
|
||
[dependencies] | ||
near-sdk = { version = "5.1.0", features = ["unstable"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggest reusing version from workspace near-sdk = { workspace = true, features = ["unstable"] }
Resolves #153
Published a crate here: https://crates.io/crates/devhub-shared
Included the crate here: https://github.com/Tguntenaar/devhub-cache-api