New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add all-day report indicators throughout UI #3024

Open

ysf-simsoft opened this issue May 15, 2020 · 0 comments · May be fixed by #3071

Labels

D2 [ ~4h ] enhancement

Milestone

Contributor

ysf-simsoft commented May 15, 2020

Currently, when creating a report if duration field is left blank, that report is considered to be an all-day event. However this consideration is vague because of two reasons:

Entering a time (hour:minute) for an all-day event creates ambiguity.
Throughout the UI there is no indication of whether an event is an all-day event or not (except ReportCalendar week, day, list-day views).

Prospective solution would be;

When creating/editing a report, either;
1. Allow user to explicitly choose whether this report is an all-day event or not.
  - Add a checkbox under the calendar with label "Create all-day event".
  - If checkbox is checked;
    1. Set duration to null and hide/disable the duration field.
    2. Disallow time selection in calendar.
    3. Automatically set time to 00:00 on selected engagementDate.
2. Keep current behavior. If duration is set to 0 (zero) or left blank, consider it as an all-day event.
  - Add a hint/message under the duration field such as; "If duration is blank or 0 an all-day event will be created".
  - Allow user to select time regardless of duration value.
When displaying reports throughout the UI;
1. If event is an all-day event; don't display time and add an indicator next to engagementDate such as; 05-05-2020 (all day)
2. If event is not an all-day event; display start and end times along with engagementDate such as; 05-05-2020 01:00-03:00

Currently, if duration is set to null, in ReportCalendar component, events are displayed in all days section on week, day, list-day views.

The text was updated successfully, but these errors were encountered:

ysf-simsoft added enhancement refine more labels

ysf-simsoft assigned ysf-simsoft and VassilIordanov

ysf-simsoft added the D2 [ ~4h ] label

VassilIordanov added this to the 2020 June milestone

ysf-simsoft added a commit that referenced this issue


          #3024: Extract date and duration fields from report form

ffe89e6

Move those fields to a dedicated component in order to implement
all-day related features in isolation.

ysf-simsoft added a commit that referenced this issue


          #3024: Make all-day logic more obvious in report form

ecf37ed

Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.

ysf-simsoft added a commit that referenced this issue


          #3024: Extract date and duration fields from report form

4e9442c

Move those fields to a dedicated component in order to implement
all-day related features in isolation.

ysf-simsoft added a commit that referenced this issue


          #3024: Make all-day logic more obvious in report form

36de6a8

Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.

ysf-simsoft added a commit that referenced this issue


          #3024: Extract date and duration fields from report form

4cf1c39

Move those fields to a dedicated component in order to implement
all-day related features in isolation.

ysf-simsoft added a commit that referenced this issue


          #3024: Make all-day logic more obvious in report form

cfa3e26

Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.

ysf-simsoft linked a pull request

that will close this issue

Add all day report indicators #3071

Draft

14 tasks

ysf-simsoft added a commit that referenced this issue


          #3024: Extract date and duration fields from report form

9ca8def

Move those fields to a dedicated component in order to implement
all-day related features in isolation.

ysf-simsoft added a commit that referenced this issue


          #3024: Make all-day logic more obvious in report form

2d89fb8

Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.

ysf-simsoft added a commit that referenced this issue


          #3024: Extract date and duration fields from report form

80d2af1

Move those fields to a dedicated component in order to implement
all-day related features in isolation.

ysf-simsoft added a commit that referenced this issue


          #3024: Make all-day logic more obvious in report form

b9eed26

Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.

ysf-simsoft added a commit that referenced this issue


          #3024: Extract date and duration fields from report form

e179e99

Move those fields to a dedicated component in order to implement
all-day related features in isolation.

ysf-simsoft added a commit that referenced this issue


          #3024: Make all-day logic more obvious in report form

b285599

Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.

cemalettin-work pushed a commit that referenced this issue


          #3024: Extract date and duration fields from report form

ba32bbb

Move those fields to a dedicated component in order to implement
all-day related features in isolation.

cemalettin-work pushed a commit that referenced this issue


          #3024: Make all-day logic more obvious in report form

36404a8

Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.

cemalettin-work added a commit that referenced this issue


          #3024: Remove unnecessary useEffect logic

673b781

cemalettin-work added a commit that referenced this issue


          #3024: Add all day indicators to calendars, maps etc

5af227c

cemalettin-work added a commit that referenced this issue


          #3024: Fix test failing - text formatting, refactoring

df1d0d1

cemalettin-work self-assigned this

cemalettin-work pushed a commit that referenced this issue


          #3024: Extract date and duration fields from report form

23cf744

Move those fields to a dedicated component in order to implement
all-day related features in isolation.

cemalettin-work pushed a commit that referenced this issue


          #3024: Make all-day logic more obvious in report form

1d5c034

Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.

cemalettin-work added a commit that referenced this issue


          #3024: Remove unnecessary useEffect logic

012f3cf

cemalettin-work added a commit that referenced this issue


          #3024: Add all day indicators to calendars, maps etc

391236b

cemalettin-work added a commit that referenced this issue


          #3024: Fix test failing - text formatting, refactoring

a3f4347

cemalettin-work added a commit that referenced this issue


          #3024: Remove unnecessary useEffect logic

cemalettin-work added a commit that referenced this issue


          #3024: Add all day indicators to calendars, maps etc

520461b

cemalettin-work added a commit that referenced this issue


          #3024: Fix test failing - text formatting, refactoring

4c2b8c4

cemalettin-work added a commit that referenced this issue


          #3024: Fix Report import by moving report logic

ecbda74

cemalettin-work added a commit that referenced this issue


          #3024: Improve styling/responsiveness

b0e8885

cemalettin-work added a commit that referenced this issue


          #3024: Fix tests and import Report issue

32a7c1d

cemalettin-work added a commit that referenced this issue


          #3024: Remove unnecessary top-level label on small width

2c8a389

Also fine tune column sizes on engagement planning part

cemalettin-work added a commit that referenced this issue


          #3024: Remove unnecessary top-level label on small width

854c338

Also fine tune column sizes on engagement planning part

cemalettin-work pushed a commit that referenced this issue


          #3024: Extract date and duration fields from report form

e343c86

Move those fields to a dedicated component in order to implement
all-day related features in isolation.

cemalettin-work pushed a commit that referenced this issue


          #3024: Make all-day logic more obvious in report form

70e36e4

Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.

cemalettin-work added a commit that referenced this issue


          #3024: Remove unnecessary useEffect logic

5171ff0

cemalettin-work added a commit that referenced this issue


          #3024: Add all day indicators to calendars, maps etc

dd2c2a5

cemalettin-work added a commit that referenced this issue


          #3024: Fix test failing - text formatting, refactoring

a380a53

cemalettin-work added a commit that referenced this issue


          #3024: Fix Report import by moving report logic

a92a719

cemalettin-work added a commit that referenced this issue


          #3024: Improve styling/responsiveness

13bc8e9

cemalettin-work added a commit that referenced this issue


          #3024: Fix tests and import Report issue

5c580a9

cemalettin-work added a commit that referenced this issue


          #3024: Remove unnecessary top-level label on small width

418d296

Also fine tune column sizes on engagement planning part

cemalettin-work pushed a commit that referenced this issue


          #3024: Extract date and duration fields from report form

edf5ed5

Move those fields to a dedicated component in order to implement
all-day related features in isolation.

cemalettin-work pushed a commit that referenced this issue


          #3024: Make all-day logic more obvious in report form

Add allDay and fullWidth props to DatePicker in order to provide needed
functionality for all-day events.

cemalettin-work added a commit that referenced this issue


          #3024: Remove unnecessary useEffect logic

33bd153

cemalettin-work added a commit that referenced this issue


          #3024: Add all day indicators to calendars, maps etc

612af01

cemalettin-work added a commit that referenced this issue


          #3024: Fix test failing - text formatting, refactoring

bf34355

cemalettin-work added a commit that referenced this issue


          #3024: Fix Report import by moving report logic

b0f2788

cemalettin-work added a commit that referenced this issue


          #3024: Improve styling/responsiveness

a87dab2

cemalettin-work added a commit that referenced this issue


          #3024: Fix tests and import Report issue

fb53fa7

cemalettin-work added a commit that referenced this issue


          #3024: Remove unnecessary top-level label on small width

1a85940

Also fine tune column sizes on engagement planning part

gjvoosten removed the refine more label

gjvoosten unassigned VassilIordanov, ysf-simsoft and cemalettin-work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment