Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colors in portal dark theme layer list don't quite fit after update #2376

Open
iannesbitt opened this issue Apr 19, 2024 · 1 comment · May be fixed by #2377
Open

Colors in portal dark theme layer list don't quite fit after update #2376

iannesbitt opened this issue Apr 19, 2024 · 1 comment · May be fixed by #2377
Assignees
@iannesbitt
Labels
bug DRP Issues related to the Defense Resiliency Platform portal theming Fixing and improving styles and theme options for Portals portals Anything related to portals

Comments

@iannesbitt
Copy link
Contributor

Describe the bug
The dark theme needs to be refreshed after the updates to the light theme from 2.28.0. Dark theme colors are sometimes too dark to distinguish from the background.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://drp.dataone.org/portals/drp-data
  2. Look at layer list
  3. See issue

Expected behavior
Theme colors should be readable.

Screenshots
Screen Shot 2024-04-19 at 15 57 46

Desktop (please complete the following information):

  • OS: all
  • Browser: all
  • Version: all

Smartphone (please complete the following information):

  • Device: all
  • OS: all
  • Browser: all
  • Version: all

Additional context
n/a
@iannesbitt iannesbitt added bug portals Anything related to portals DRP Issues related to the Defense Resiliency Platform labels Apr 19, 2024
@iannesbitt iannesbitt self-assigned this Apr 19, 2024
@iannesbitt iannesbitt changed the title Colors in portal dark layer list don't quite fit after update Colors in portal dark theme layer list don't quite fit after update Apr 19, 2024
iannesbitt added a commit that referenced this issue Apr 19, 2024
@iannesbitt
adding colors to dark theme for #2376
d140b17
@iannesbitt iannesbitt linked a pull request Apr 19, 2024 that will close this issue
Open
@iannesbitt iannesbitt linked a pull request Apr 19, 2024 that will close this issue
Adding colors to dark theme for #2376 #2377
Open
@robyngit robyngit added this to the 2.29.0 milestone Apr 23, 2024
@robyngit robyngit modified the milestones: 2.29.0, 2.30.0 May 6, 2024
@robyngit robyngit modified the milestones: 2.30.0, 2.31.0 Jun 20, 2024
@robyngit robyngit removed this from the 2.31.0 milestone Sep 9, 2024
@robyngit
Copy link
Member

robyngit commented Sep 9, 2024

Notes about implementing a more robust color theme system for portals: https://docs.google.com/document/d/1Eb0uixayVeEgO0AcIEjDO6J5555A_CA1BK0nZp1s-uk/edit#heading=h.f99d70q8f3z0

@robyngit robyngit added the portal theming Fixing and improving styles and theme options for Portals label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iannesbitt iannesbitt

Labels
bug DRP Issues related to the Defense Resiliency Platform portal theming Fixing and improving styles and theme options for Portals portals Anything related to portals
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding colors to dark theme for #2376 NCEAS/metacatui
2 participants
@iannesbitt @robyngit