diff --git a/include/ngl/Vec4.h b/include/ngl/Vec4.h index d3dd2baa..02b82937 100644 --- a/include/ngl/Vec4.h +++ b/include/ngl/Vec4.h @@ -261,12 +261,6 @@ class NGL_DLLEXPORT Vec4 //---------------------------------------------------------------------------------------------------------------------- Vec4 &operator=(const Vec3 &_v) noexcept; - //---------------------------------------------------------------------------------------------------------------------- - /// @brief assignment operator set the current vector to rhs - /// @param[in] _v the vector to set - /// @returns a new vector - //---------------------------------------------------------------------------------------------------------------------- - Vec4 &operator=(Real _v) noexcept; //---------------------------------------------------------------------------------------------------------------------- /// @brief negate the vector components diff --git a/src/Vec4.cpp b/src/Vec4.cpp index a9adb4b8..bb639938 100644 --- a/src/Vec4.cpp +++ b/src/Vec4.cpp @@ -238,14 +238,6 @@ Vec4 &Vec4::operator=(const Vec3 &_v) noexcept return *this; } -Vec4 &Vec4::operator=(Real _v) noexcept -{ - m_x = _v; - m_y = _v; - m_z = _v; - m_w = 0.0f; - return *this; -} Real Vec4::lengthSquared() const noexcept { diff --git a/tests/Vec3Tests.cpp b/tests/Vec3Tests.cpp index 7b2d19e9..570c20c2 100644 --- a/tests/Vec3Tests.cpp +++ b/tests/Vec3Tests.cpp @@ -150,6 +150,7 @@ TEST(Vec3, AssignOperator) EXPECT_FLOAT_EQ(test[0], copy[0]); EXPECT_FLOAT_EQ(test[1], copy[1]); EXPECT_FLOAT_EQ(test[2], copy[2]); + } TEST(Vec3, fromGLM)