Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

h5netcdf read #307

Merged
merged 93 commits into from
Jul 25, 2024
Merged

h5netcdf read #307

merged 93 commits into from
Jul 25, 2024

Conversation

davidhassell
Copy link
Contributor

@davidhassell davidhassell commented Jun 20, 2024

Fixes #285 and #286

  • Implements reading of netCDF files with h5netcdf, which also allows files in S3-compatible storage to be read.
  • Implements netcdf_flattener in-house, rather than with an import. The new flattener can flatten files opened with h5netcdf, can flatten all CF references, and is more extensible to future CF references.
  • Creates netcdf_indexer (based on netCDF4 functionality) that allows orthogonal indexing on h5netcdf variables.

davidhassell and others added 26 commits July 23, 2024 16:08
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Co-authored-by: Sadie L. Bartholomew <[email protected]>
Copy link
Member

@sadielbartholomew sadielbartholomew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all of my feedback. I've done a final sanity check and it is all good. Great stuff, please merge!

@davidhassell
Copy link
Contributor Author

Thanks again for your customary careful and detailed review - merging now ....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request netCDF read Relating to reading netCDF datasets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow access to netCDF-4 files in S3 object stores
2 participants