Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Data.__contains__ to evaluate subarray presence #349

Open
sadielbartholomew opened this issue Mar 10, 2022 · 0 comments
Open

Extend Data.__contains__ to evaluate subarray presence #349

sadielbartholomew opened this issue Mar 10, 2022 · 0 comments
Labels
dask Relating to the use of Dask enhancement New feature or request low priority

Comments

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Mar 10, 2022

Presently Data.__contains__ only tests whether scalars are contained within a given data array, but the method could be extended to become more general, namely to check for the membership of sub-arrays, with agreed behaviour for selected cases. Assuming, and when, Python array standards such as numpy support this, we agreed to re-consider the scope of __contains__ in this manner.

See #320 (comment) for context and brief discussion.

@sadielbartholomew sadielbartholomew added the dask Relating to the use of Dask label Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dask Relating to the use of Dask enhancement New feature or request low priority
Projects
None yet
Development

No branches or pull requests

1 participant