Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subsume ESMF regrid logging configuration under log level #286

Open
sadielbartholomew opened this issue Dec 13, 2021 · 0 comments
Open

Subsume ESMF regrid logging configuration under log level #286

sadielbartholomew opened this issue Dec 13, 2021 · 0 comments
Assignees
Labels
API review (4.0.0) enhancement New feature or request question General question

Comments

@sadielbartholomew
Copy link
Member

sadielbartholomew commented Dec 13, 2021

The cf.regrid_logging flag can turn the logging from ESMF regridding on and off as required under cf, but I think it would be cleaner and more natural to the user if it such logging was controlled under the cf logging system.

More specifically I propose that ESMF logging is switched on when the cf.log_level is set to 'INFO' (2) or higher, otherwise off, and perhaps we can, consistently with other functions, provide a verbose keyword argument to the two regridding methods which can override the global log level if a user does want to force the ESMF logging to be enabled. Then we can remove this flag.

Happy to consider other thoughts on this, though, if anyone thinks the current set-up is preferable or there is a better alternative way to manage the configuration of the ESMF logging.

@sadielbartholomew sadielbartholomew changed the title Integrate logging systems Subsume ESMF regrid logging config. under log level Dec 14, 2021
@sadielbartholomew sadielbartholomew changed the title Subsume ESMF regrid logging config. under log level Subsume ESMF regrid logging configuration under log level Dec 14, 2021
@sadielbartholomew sadielbartholomew added enhancement New feature or request question General question labels Dec 14, 2021
@sadielbartholomew sadielbartholomew self-assigned this Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API review (4.0.0) enhancement New feature or request question General question
Projects
None yet
Development

No branches or pull requests

1 participant