Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formalise compression and filters arguments in reduce_chunk, avoid numcodecs.Codec objects #125

Open
markgoddard opened this issue Jul 20, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@markgoddard
Copy link

Currently we pass numcodecs.Codec objects as the compression and filters arguments to reduce_chunk. This is convenient for the local storage implementation, but does leave us reliant on the numcodecs library in what might be considered our internal "storage backend API".

It would be better to describe these algorithms using a Plain Old Data (POD) type, such as a dict.

See the original discussion.

As outlined in my proposal, I suggest we use arguments in the following format:

reduce_chunk(
    compression={"compression": {"id": "zlib"}},
    filters=[{"id": "shuffle", "dtype": "uint32"}]),
    ...
)

This aligns with the format used in the S3 active storage server API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant