Fixes to the overland routing off configuration. #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 2, 2019 13:28
…l need to add landRunoff output var for post-proc WB closure. Answer changes when ovrt is off.
…is off to pass-through always. Should add separate accounting eventually, but for now tracked with GW outflow. Answer changes when ovrt is off and non-UDMP.
rcabell
approved these changes
Jun 3, 2019
|
CI testing results are as expected - answer changes in hydro outputs and restart in NWM long-range configuration only (only tested configuration where OVRTSWCRT=0). |
jmccreight
reviewed
Jun 3, 2019
| call gw_sum_real(ct_bas8,numbasns,gnumbasns,basnsInd) | ||
| #endif | ||
| sum_perc = sum_perc8 | ||
| sum_perc_surf = sum_perc8_surf |
There was a problem hiding this comment.
why do it in double precision and then throw it away?
There was a problem hiding this comment.
there's probably sumthing hiding in gw_sum_real
There was a problem hiding this comment.
No idea - I just duplicated what was already in the code. Pre-dates me.
jmccreight
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answer changes only when overland routing is off (affects UDMP and non-UDMP). Moved surface runoff that was mapped through GW buckets in non-UDMP configs to behave as pass-through only (as opposed to bucket attenuation; ugdrunoff is still through bucket). Both are combined for gwout. Confirmed ncores and perfect restarts. Needs at least one new output var to fully track all WB components (TBD).